Fix change event not fired on type after paste

[millerdev]

Steps to reproduce the bug:

• Setup change event listener to record change events in the console. Something like this:

  var i = 0;
  editor.on("change", function () {
      console.log("change", i++);
  });

• Paste some text into the editor and note change event number in console.
• Type a single character.

Expected:
Change event should fire after typing (should see new change event number since paste).

Observed:
Change event is not fired.

[f1ames]

Hello @millerdev,
thanks for the PR. We will try to look into it soon. Just as a notice, here is a related bug ticket from our official bug tracker: http://dev.ckeditor.com/ticket/13763.

[aik099]

@f1ames , could you also look at #297?

[millerdev]

@f1ames is there anything else needed to get this approved/merged? I'd love to see this bug fixed on the main line.

[f1ames]

Hello @millerdev,
we will look into it when fixing #13763. However, the fix is not scheduled for any upcoming release at the moment so it is hard to say when exactly we can take care of this one.

In the meantime you could make two improvements which will help us with this fix:

• Rebase your branch on current master. We recently added integration with Travis CI so after rebasing you could see if all tests passes with your change (https://travis-ci.org/ckeditor/ckeditor-dev/pull_requests).
• Provide manual tests.

Thank you!

[millerdev]

Thanks @f1ames, I'll work on those things. Out of curiosity, why are manual tests needed if I have a fully automated test for this bug? The contributing guidelines imply that manual tests are necessary only if it is not possible to test automatically.

[mlewand]

I've explained it a little in #297 (comment). It's true that docs needs to be updated here, we'll update them shortly.

[millerdev]

@f1ames @mlewand rebased, all tests passing on travis, manual test added.

[djdenv]

👍 Can we get this targeted for an upcoming release soon?

[mlewand]

Sorry, we're in the middle of 4.7.1 release testing phase, thus we're unable to fit it in. But I'll put it in backlog to review it for 4.7.2, thanks for the feedback!

Also @djdenv you add 👍 reaction to the pull request description to show your support 😉.

[djdenv]

Thank you. Yes, I'm using the thumbs up to show support for merging this PR. 😉

[Comandeer]

This PR was used as a base for #666. After adding tests and fixing some code style issues, the solution initially proposed by @millerdev was merged into our master and it'll become part of 4.7.3 release. Thanks for contributing!