Ticket #11757 Imperfections in moono ui styles #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey. Thanks for the thorough review of the UI styles :) We'll check it in 4.4.1. |
|
There's an update regarding this PR http://dev.ckeditor.com/ticket/11757#comment:3 |
|
I merged commits that passed review into master in f5acc04. One more time huge thanks @danyaPostfactum for this pull request! |
mdenburger
pushed a commit
to onehippo/ckeditor
that referenced
this pull request
Feb 13, 2017
mdenburger
pushed a commit
to onehippo/ckeditor
that referenced
this pull request
May 30, 2017
Version 1.16.1 is a Hippo-specific release (upstream only defines 1.16). It includes two fixes for the inline CKEditor: - ckeditor#82 ("CodeMirror hides inline editor toolbar") - ckeditor#91 ("CKeditor Inline mode: context menu not shown in firefox and chrome") Both are very useful to have in the Channel Manager, which will use the inline version of CKEditor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://dev.ckeditor.com/ticket/11757
Sorry, initially I just wanted to fix ugly top margin of "browse server" buttons. But having started to fix css, I could not stop )
Button top margin still needs a proper fix. This is just a temporary correction.