Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.7.3: Spell Checker blocks editing when remote spell checker is offline #74

Closed
berenddeboer opened this issue Oct 25, 2017 · 1 comment

Comments

@berenddeboer
Copy link

When you go to "Check Spelling" and www.webspellchecker.net is unavailable, you get the dialog box saying "Spell Checker" in the title and the "Cancel" button at the bottom, and otherwise a blank page.

But the real problem is that you cannot close this dialog box.

There is a JavaScript error in the console:

  Uncaught TypeError: Cannot read property 'setDisable' of null
    at Object.<anonymous> (wsc.js?t=H8DA:91)
    at CKEDITOR.dialog.n (ckeditor.js?oyees7:10)
    at CKEDITOR.dialog.CKEDITOR.event.CKEDITOR.event.fire (ckeditor.js?oyees7:12)
    at CKEDITOR.dialog.<anonymous> (ckeditor.js?oyees7:587)
    at CKEDITOR.dom.element.n (ckeditor.js?oyees7:10)
    at CKEDITOR.dom.element.CKEDITOR.event.CKEDITOR.event.fire (ckeditor.js?oyees7:12)
    at HTMLAnchorElement.<anonymous> (ckeditor.js?oyees7:64)

The fix would be to catch this error.

Apologies for not submitting the I suppose patch, as the uncompressed version doesn't work with my Drupal setup (Drupal 7 + wysiwyg module), and the compressed js is unreadable.

The problem is easy to verify: just add a line like 127.0.0.1 www.webspellchecker.net to your /etc/hosts file and you can demonstrate the problem.

@f1ames
Copy link
Contributor

f1ames commented Oct 26, 2017

@berenddeboer thank you for reporting. This is a WebSpellChecker issue and should be reported directly on their issue page - https://github.com/WebSpellChecker/ckeditor-plugin-wsc/issues.

Could I ask you to rereport it there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants