Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.7.3: Spell Checker blocks editing when remote spell checker is offline #46

Closed
berenddeboer opened this issue Oct 27, 2017 · 2 comments
Labels
Milestone

Comments

@berenddeboer
Copy link

When you go to "Check Spelling" and www.webspellchecker.net is unavailable, you get the dialog box saying "Spell Checker" in the title and the "Cancel" button at the bottom, and otherwise a blank page.

But the real problem is that you cannot close this dialog box.

There is a JavaScript error in the console:

  Uncaught TypeError: Cannot read property 'setDisable' of null
    at Object.<anonymous> (wsc.js?t=H8DA:91)
    at CKEDITOR.dialog.n (ckeditor.js?oyees7:10)
    at CKEDITOR.dialog.CKEDITOR.event.CKEDITOR.event.fire (ckeditor.js?oyees7:12)
    at CKEDITOR.dialog.<anonymous> (ckeditor.js?oyees7:587)
    at CKEDITOR.dom.element.n (ckeditor.js?oyees7:10)
    at CKEDITOR.dom.element.CKEDITOR.event.CKEDITOR.event.fire (ckeditor.js?oyees7:12)
    at HTMLAnchorElement.<anonymous> (ckeditor.js?oyees7:64)

The fix would be to catch this error.

Apologies for not submitting the I suppose patch, as the uncompressed version doesn't work with my Drupal setup (Drupal 7 + wysiwyg module), and the compressed js is unreadable.

The problem is easy to verify: just add a line like 127.0.0.1 www.webspellchecker.net to your /etc/hosts file and you can demonstrate the problem.

PS: I initially reported this problem at ckeditor, and they referred me here.

@jshaptala
Copy link
Member

Hi @berenddeboer ,

Thank you for the issue reported. We do confirm that we are able to reproduce the described problem. We plan to include the fix to one of our upcoming releases - 4.9.5. The preliminary ETA is mid December 2017. However, you shouldn't experience the problem further as now the WebSpellChecker Cloud is stabilized.

As soon as the fix is released, we will inform you.

Sincerely,

@jshaptala jshaptala added this to the 4.9.5 milestone Nov 20, 2017
@jshaptala jshaptala added the bug label Nov 20, 2017
jalners added a commit that referenced this issue Nov 24, 2017
…ecker blocks editing when remote spell checker is offline
@jshaptala
Copy link
Member

Hi, this issue was fixed as a part of release 4.9.5 in December 2017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants