Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAWS leaves forms mode after pressing enter key in an inline CKEditor instance #1034

Closed
jswiderski opened this issue Oct 11, 2017 · 8 comments
Labels
accessibility Issue related to accessibility. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone

Comments

@jswiderski
Copy link
Contributor

jswiderski commented Oct 11, 2017

Are you reporting a feature request or a bug?

Bug

Check if the issue is already reported

Provide detailed reproduction steps (if any)

  1. AUTO FORMS MODE - According to this link - https://tink.uk/understanding-screen-reader-interaction-modes/, forms mode is being activated automatically whenever you enter a form filed. It is done automatically and signalized with a beep.
    MANUAL FORMS MODE - According to this link http://doccenter.freedomscientific.com/doccenter/doccenter/rs11f929e9c511/2014-12-02_webpagetesting-l1/02_JAWS-Settings.htm you can enable Manual Forms Mode by pressing INSERT+F2, selecting Settings Center, typing Forms Mode and switching from Auto to Manual. To enable Forms mode when on page, you need to press Enter. To disable it, you need to press Esc.

  2. Enable JAWS

  3. Open inline editor sample and focus editor (There will be a beep signalizing entering the forms mode)

  4. Clear editor contents, type few characters and press enter

Expected result

While editor is focused and Forms Mode hasn't been disabled with Esc (only in Manual Forms Mode), the Forms Mode should be on.

Actual result

In Inline editor Forms Mode gets disabled with every enter key pressed and you actually need to press enter twice with every new line to be able to still type in the editor.

If you try the same steps with native contenteditable element e.g. https://codepen.io/j_swiderski/pen/NvOdWz, you will see it works fine there.

Other details

  • Browser: Firefox
  • OS: Windows
  • CKEditor version: 4.0+
  • Installed CKEditor plugins: N/A
@jswiderski jswiderski added accessibility Issue related to accessibility. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. type:bug A bug. labels Oct 11, 2017
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Nov 20, 2017
@mlewand
Copy link
Contributor

mlewand commented Mar 1, 2018

I can no longer reproduce this issue, either for older CKEditor (e.g. 4.6.0) as well for the latest CKEditor.

I have used the old "Replace Textarea with Inline Editor" as it contains an inline editor in a form element.

Repro steps are:

  1. Open the old "Replace Textarea with Inline Editor" sample.
  2. Navigate to the editor.
  3. Type "h" few times.
  4. Press "Enter" twice.
  5. Type "h" few times.

Expected & Actual

"h" character is typed into the editable. If bug was present it would move to a next header.

Below a screencast:

JAWS version: 2018.1802.78
Firefox version: 58.0.2
OS: Windows 7

@mlewand mlewand added status:pending and removed status:confirmed An issue confirmed by the development team. labels Mar 1, 2018
@mlewand
Copy link
Contributor

mlewand commented Mar 1, 2018

I was able to reproduce it though with Firefox ESR 52.6.0 and JAWS 18.0.2945. However we'd like to hear from you if the issue is still reproducible with the latest JAWS version.

@mlewand mlewand changed the title In Inline CKEditor used with JAWS, Forms Mode is exited with every Enter key pressed. In Inline CKEditor used with JAWS, Forms Mode is exited with every Enter key pressed Mar 12, 2018
@mlewand
Copy link
Contributor

mlewand commented Mar 12, 2018

I was able to set up latest JAWS (though it was a true PITA). The source of the problem is explained in #1780.

Reason why @jswiderski was not able to reproduce the issue in his first comment was that he was using div with contenteditable attr, but there was no [role=textbox] (like here https://codepen.io/mlewand/pen/EEjzrx). With the role attribute the issue exists even without CKEditor. However we can safely add aria-multiline attribute which solves the issue.

@mlewand mlewand added status:confirmed An issue confirmed by the development team. and removed status:pending labels Mar 12, 2018
@mlewand mlewand added this to the Backlog milestone Mar 12, 2018
@mlewand mlewand changed the title In Inline CKEditor used with JAWS, Forms Mode is exited with every Enter key pressed JAWS leaves forms mode after pressing enter key in an inline CKEditor instance Mar 12, 2018
@Comandeer
Copy link
Member

Closed in #1780.

@mlewand mlewand modified the milestones: Backlog, 4.10.0 Mar 12, 2018
@mlewand
Copy link
Contributor

mlewand commented Mar 12, 2018

Issue has been reviewed. It landed to our upcoming 4.10.0 release, developed in next branch (currently there's no ETA, as soon as we have it it will be posted on https://github.com/ckeditor/ckeditor-dev/milestones).

Meanwhile you could have a look at it on our online preview page: https://ckeditor4-preview.ckeditor.com/next/samples/old/inlinetextarea.html

@jswiderski
Copy link
Contributor Author

I also confirm that adding role=textbox to native editable element just like in CKEditor, breaks Forms Mode and adding the aria-multiline="true" fixes it.

@JulesAchiel
Copy link

Is this issue fixed in 4.10 ?

@mlewand
Copy link
Contributor

mlewand commented Mar 19, 2018

@JulesAchiel yes it is, please have a look at #1034 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

4 participants