Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Upload Image plugin by default #1249

Closed
mlewand opened this issue Nov 28, 2017 · 0 comments
Closed

Enable Upload Image plugin by default #1249

mlewand opened this issue Nov 28, 2017 · 0 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:uploadimage The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Milestone
4.8.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Nov 28, 2017 •
edited
Loading

Are you reporting a feature request or a bug?

Other, task

Provide detailed reproduction steps (if any)

After adding a feature to inline Word images in CKEditor 4 we would want to encourage our users to upload them to backend (keeping images as base64 encoded src is not good idea).

For that we'll enable uploadimage plugin by default, so the only remaining part is to add config.imageUploadUrl property.

The Upload Image plugin should be added to the standard and full presets.

Also we want to skip error reporting in case of missing config.imageUploadUrl property. Currently upload image will report an error if no upload URL is provided.

Instead it should silently pass, and not register any plugin features.
@mlewand mlewand added type:task Any other issue (refactoring, typo fix, etc). plugin:uploadimage The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. labels Nov 28, 2017
@mlewand mlewand added this to the 4.8.0 milestone Nov 28, 2017
@mlewand mlewand mentioned this issue Nov 28, 2017
Closed
@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Nov 29, 2017
@Comandeer Comandeer mentioned this issue Nov 29, 2017
Merged
2 tasks
@mlewand mlewand changed the title Upload image should no longer throw a missing configuration error Enable Upload Image plugin by default Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:uploadimage The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
4.8.0
Development

No branches or pull requests
1 participant
@mlewand