Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions plugin requests should be throttled #1972

Closed
mlewand opened this issue May 14, 2018 · 1 comment
Closed

Mentions plugin requests should be throttled #1972

mlewand opened this issue May 14, 2018 · 1 comment
Labels
changelog:skip A changelog entry should not be added for a given issue. plugin:mentions The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.10.0

Comments

@mlewand
Copy link
Contributor

mlewand commented May 14, 2018 •
edited
Loading

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

Currently, given that config.feed is set to backend URL, our mentions plugin will issue a HTTP request for each typed character. That might be expensive.

For instance, imagine you type @johnny, you're issuing (depending on min chars) requests for jo, joh, john (etc.).

To mitigate this issue, requests should be throttled. By default I'd say somewhere around 70-120 ms each.

CKEDITOR.tools.eventsBuffer function provides handling for that.

Also throttling thershould should be configurable in mentions config object.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.10.0
  • Installed CKEditor plugins: mentions
@mlewand mlewand added type:feature A feature request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. plugin:mentions The plugin which probably causes the issue. labels May 14, 2018
This was referenced May 17, 2018
Merged
Closed
Closed
@mlewand mlewand added the changelog:skip A changelog entry should not be added for a given issue. label Jun 12, 2018
@mlewand mlewand added this to the 4.10.0 milestone Jun 12, 2018
@mlewand
Copy link
Contributor Author

mlewand commented Jun 12, 2018

Fixed with #1983.

@mlewand mlewand closed this as completed Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:skip A changelog entry should not be added for a given issue. plugin:mentions The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.10.0
Development

No branches or pull requests
1 participant
@mlewand