Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji plugin should support keywords #2181

Closed
mlewand opened this issue Jun 27, 2018 · 2 comments
Closed

Emoji plugin should support keywords #2181

mlewand opened this issue Jun 27, 2018 · 2 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:emoji The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.11.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Jun 27, 2018

Type of report

Feature request

Provide description of the new feature

Open sample with Emoji plugin.
Start typing :smile

Expected

slightly_smiling_face emoji is being matched too

Actual

slightly_smiling_face emoji is not matched

Additional Details

Unicode specifies keywords associated with each smiley, that increases the likelihood of matching given emoji. We should add a support for that too.
@mlewand mlewand added type:feature A feature request. status:confirmed An issue confirmed by the development team. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:major Any docs related issue that should be merged into a major branch. plugin:emoji The plugin which probably causes the issue. labels Jun 27, 2018
@mlewand mlewand added this to the 4.11.0 milestone Jun 27, 2018
@mlewand mlewand mentioned this issue Jun 27, 2018
Closed
@wwalc wwalc mentioned this issue Jun 27, 2018
Closed
@wwalc
Copy link
Member

wwalc commented Jun 27, 2018

Note: keywords should have higher priority than CLDR. So first display all emojis that match keywords, then look for CLDR matches.

@mlewand mlewand changed the title Mentions plugin should support keywords Emoji plugin should support keywords Jun 27, 2018
@jacekbogdanski jacekbogdanski mentioned this issue Jul 16, 2018
Closed
@mlewand mlewand modified the milestones: 4.11.0, Backlog Oct 17, 2018
@msamsel msamsel mentioned this issue Oct 26, 2018
Closed
2 tasks
@mlewand mlewand mentioned this issue Oct 29, 2018
Closed
@mlewand mlewand modified the milestones: Backlog, 4.11.0 Oct 29, 2018
@mlewand
Copy link
Contributor Author

mlewand commented Oct 29, 2018

Closed by #2461.

@mlewand mlewand closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:emoji The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging a pull request may close this issue.

Introduce emoji dropdown ckeditor/ckeditor4
2 participants
@wwalc @mlewand