Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtered emoji order should be improved #2527

Closed
mlewand opened this issue Oct 29, 2018 · 1 comment
Closed

Filtered emoji order should be improved #2527

mlewand opened this issue Oct 29, 2018 · 1 comment
Assignees
@msamsel
Labels
plugin:emoji The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.3

Comments

@mlewand
Copy link
Contributor

mlewand commented Oct 29, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

After fixing #2181 the sorting order of emoji has changed. Previously it was better.

  1. Open editor with Emoji plugin.
  2. Type :smiling.

Expected result

Emojis whose id starts with smiling should appear first.

Old behavior was:

Previous (4.10.1) emoji sorting

Actual result

Current emoji sorting order

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.11.0
@mlewand mlewand added type:bug A bug. status:confirmed An issue confirmed by the development team. regression This issue is a regression. target:minor Any docs related issue that can be merged into a master or major branch. plugin:emoji The plugin which probably causes the issue. labels Oct 29, 2018
@mlewand mlewand added this to the 4.11.1 milestone Oct 29, 2018
@mlewand mlewand modified the milestones: 4.11.1, 4.11.2 Nov 7, 2018
@msamsel msamsel self-assigned this Dec 18, 2018
@msamsel msamsel mentioned this issue Dec 18, 2018
Merged
2 tasks
@mlewand mlewand modified the milestones: 4.11.2, 4.11.3 Jan 3, 2019
@mlewand
Copy link
Contributor Author

mlewand commented Feb 12, 2019

Closed with #2689.

@mlewand mlewand closed this as completed Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
plugin:emoji The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.3
Development

No branches or pull requests
2 participants
@mlewand @msamsel