Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple keyboard shortcuts (for a single command) should be displayed in a11yhelp #2519

Closed
mlewand opened this issue Oct 26, 2018 · 1 comment · Fixed by #2520
Closed

Multiple keyboard shortcuts (for a single command) should be displayed in a11yhelp #2519

mlewand opened this issue Oct 26, 2018 · 1 comment · Fixed by #2520
Assignees
@jacekbogdanski
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Oct 26, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

Recently we added a new keystroke to link command so it now handles both ctrl + l and ctrl + l. This is not reflected by a11yhelp dialog as it uses only a single keystroke.

  1. Open page with CKE4 including link and a11yhelp plugins.
  2. Focus the editor.
  3. Press alt+0.
  4. Scroll to "Link command" section.

Expected result

The line should read "Press Ctrl+K / Ctrl+L".

Actual result

It lists only a single keystroke: "Press Ctrl+K".

image

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.11.0
@mlewand mlewand added type:bug A bug. status:confirmed An issue confirmed by the development team. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:minor Any docs related issue that can be merged into a master or major branch. labels Oct 26, 2018
@jacekbogdanski jacekbogdanski self-assigned this Oct 26, 2018
@mlewand
Copy link
Contributor Author

mlewand commented Oct 26, 2018

Note that I have intentionally separated multiple keystrokes with a "/" character, as it simply will not require localization.

@jacekbogdanski jacekbogdanski mentioned this issue Oct 26, 2018
Merged
2 tasks
@mlewand mlewand added this to the 4.11.0 milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekbogdanski jacekbogdanski

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging a pull request may close this issue.

Accessibility Helper dialog supports multiple command keystrokes ckeditor/ckeditor4
2 participants
@mlewand @jacekbogdanski