Accessibility Helper dialog supports multiple command keystrokes #2520
Conversation
I think this is a no-brainer so we can skip this one. But yea, basically your approach would be a nice way to test it. |
| @bender-ui: collapsed | ||
| @bender-ckeditor-plugins: wysiwygarea, a11yhelp, link | ||
|
|
||
| 1. Focus the edtior. |
|
|
||
| ## Expected: | ||
|
|
||
| ### Windows/Linux |
There was a problem hiding this comment.
Actually this could be simplified, you could type it just as a list (i mean expected/unexpected section), so it's more concise.
|
|
||
| ### Windows/Linux | ||
|
|
||
| Link command is described by two keystrokes: `CTRL+L / CTRL+K`. |
There was a problem hiding this comment.
Just a detail, the button order is reversed. Not a big deal but someone might get a ❤️ attack during the testing phase. 😉
|
|
||
| // Return the keystroke representation or leave match untouched | ||
| // if there's no keystroke for such command. |
There was a problem hiding this comment.
The comment about intentionally returing unmatched string was somewhat helpful, coz it might look like a bug - while the intention is to leave placeholder not replaced.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
Included all command keystrokes if available.
I wonder if we need a unit test for proposed change. It would probably require searching for correct text by regex inside dialog HTML. WDYT?
Closes #2519