image2 add-on does not handle image URLs containing queryString (http 403 error)

[ajssd]

Type of report

Bug

Provide detailed reproduction steps (if any)

1. using the image2 add-on, choose an Image URL that contains a '?' followed by a queryString
2. observe the HTTP 403 error when the image2 code tries to add the random number to the end of the URL

Expected result

HTTP 403 error

Actual result

No error

Other details

• CKEditor version: 4.5.0+
• Installed CKEditor plugins: image2

The offending code in Image2 is this:

image.setAttribute( 'src', ( config.baseHref || '' ) + src + '?' + Math.random().toString( 16 ).substring( 2 ) );

[Comandeer]

I can confirm the issue. It's present only in dialog, when fetching image preview. The fix seems rather easy: before adding query string, check if there isn't one already.

[ajssd]

What is the reason for adding the query string anyway? I assume it's cache-related, but why would it be needed in this particular case? Can the code that adds the query string be removed completely?

[Comandeer]

The query string is added to force an update of image preview. I'm not sure if it's really needed, yet it seems to be in image plugin from the very beginning. Probably some browsers had issues with updating image preview back then.

[ajssd]

Tomas, we just upgraded to 4.13.1 and this bug is still there. Do you think you could remove the unnecessary append to the URL -- or, at least check if there is already a query string in the URL (i.e. search for "?") and if so, use "&" instead of "?".

[surli]

@Comandeer I happened to have this exact same issue when working on a custom uploader widget and testing it with images, so I opened a PR for fixing it. However it's really my first contrib on ckeditor, so might need a bit of help for providing a test to have it merged.

[CKEditorBot]

Closed in #5153

[CKEditorBot]

Closed in #5153