Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable PFW test related to filters loading #3424

Open
f1ames opened this issue Sep 17, 2019 · 7 comments
Open

Unstable PFW test related to filters loading #3424

f1ames opened this issue Sep 17, 2019 · 7 comments
Labels
status:confirmed An issue confirmed by the development team. type:failingtest A failing test.

Comments

@f1ames
Copy link
Contributor

f1ames commented Sep 17, 2019

Type of report

Failing tests

Provide detailed reproduction steps (if any)

Some PFW tests fails randomly, for example see https://travis-ci.org/ckeditor/ckeditor4/jobs/585973103 #3424 (comment). It looks like there might be some inconsistency / race condition when loading PFW filters and so sometimes the filters are not ready when test are executed.

@f1ames f1ames added type:bug A bug. type:failingtest A failing test. and removed type:bug A bug. labels Sep 17, 2019
@f1ames
Copy link
Contributor Author

f1ames commented Sep 17, 2019

I think this is the same issue which was mentioned during #835 review (see #3257 (review)) regarding the same tests failing on Edge:

image

@Dumluregn Dumluregn added the status:confirmed An issue confirmed by the development team. label Sep 18, 2019
@f1ames f1ames added this to the Next milestone Sep 18, 2019
@f1ames f1ames added the target:minor Any docs related issue that can be merged into a master or major branch. label Sep 26, 2019
@Comandeer Comandeer self-assigned this Oct 3, 2019
@f1ames f1ames removed the target:minor Any docs related issue that can be merged into a master or major branch. label Nov 12, 2019
@f1ames
Copy link
Contributor Author

f1ames commented Nov 21, 2019

Fixed in #3539.

@f1ames
Copy link
Contributor Author

f1ames commented Feb 19, 2020

Reopening since it it still an issue as we seen during recent testing phase.

@f1ames f1ames reopened this Feb 19, 2020
@f1ames f1ames removed this from the 4.13.1 milestone Mar 9, 2020
@Comandeer
Copy link
Member

They seem to fail on the first test run and only in Firefox. After that, they run smoothly. Unfortunately there is only the first run on CI, so it fails there more regularly, e.g. https://app.travis-ci.com/github/ckeditor/ckeditor4/jobs/541909640 or https://app.travis-ci.com/github/ckeditor/ckeditor4/jobs/541657054.

@Comandeer Comandeer mentioned this issue Oct 12, 2021
3 tasks
@Comandeer
Copy link
Member

It seems that Firefox does something weird during script loading and load event does not mean that script is loaded and executed. Now I'm experimenting with using afterscriptexecute event in the script loader and the initial results are promising.

@Comandeer
Copy link
Member

It seems that the issue can be reproduced in Chrome after all. So probably the issue is deeper and connected with our script loader.

@sculpt0r
Copy link
Contributor

sculpt0r commented Mar 31, 2022

That should be fixed as a part of a bigger solution, e.g. #4948

I was able to reproduce the issue (this time on Brave - chrome) only thanks to the browser plugin, which automatically refreshes the tab and stops if certain text is on the page...

All scripts are loaded, the only 404 is for favicon. Some screens, might eventually help:
Screenshot 2022-03-30 at 22 39 36
Screenshot 2022-03-30 at 22 40 55
Screenshot 2022-03-30 at 22 40 40

@sculpt0r sculpt0r removed their assignment Mar 31, 2022
@KarolDawidziuk KarolDawidziuk self-assigned this Dec 22, 2022
@KarolDawidziuk KarolDawidziuk removed their assignment Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:failingtest A failing test.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants