Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to open the dialog for the second time when it's already opened causes dialog cover to stay after dialog closing #3638

Closed
Dumluregn opened this issue Nov 8, 2019 · 2 comments · Fixed by #4688
Closed

Trying to open the dialog for the second time when it's already opened causes dialog cover to stay after dialog closing #3638

Dumluregn opened this issue Nov 8, 2019 · 2 comments · Fixed by #4688
Assignees
@Comandeer
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.16.2

Comments

@Dumluregn
Copy link
Contributor

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Go to CDN
  2. Execute CKEDITOR.instances.editor.execCommand( 'link' ) twice
  3. Close the dialog

Expected result

Dialog is closed and editor is available

Actual result

Dialog cover stays after closing dialog, editor is unavailable

Other details

This behaviour was introduced in #2413. Before it was also broken, but in different way - after calling dialog for the second time it has been hiding behind cover.

  • Browser: all
  • OS: macOS
  • CKEditor version: 4.13.0
  • Installed CKEditor plugins: dialog
@Dumluregn Dumluregn added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:dialog The plugin which probably causes the issue. labels Nov 8, 2019
@Dumluregn Dumluregn mentioned this issue Nov 11, 2019
Merged
2 tasks
@f1ames f1ames added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. size:M labels May 5, 2021
@Comandeer Comandeer self-assigned this May 10, 2021
@Comandeer
Copy link
Member

The behaviour is back to the old way of being broken – after opening dialog for the second time, it hides under the overlay. It seems that c612866 reintroduced it.

@Comandeer Comandeer mentioned this issue May 10, 2021
Merged
3 tasks
sculpt0r added a commit that referenced this issue May 19, 2021
@sculpt0r
Add changelog for #3638
17b1b89
sculpt0r added a commit that referenced this issue May 19, 2021
@sculpt0r
Add changelog for #3638
24f29b7
@sculpt0r sculpt0r linked a pull request May 19, 2021 that will close this issue
Fix for broken dialogs after opening the same one twice #4688
Merged
3 tasks
@CKEditorBot CKEditorBot added this to the 4.16.1 milestone May 19, 2021
@f1ames f1ames modified the milestones: 4.16.1, 4.16.2 May 24, 2021
@Dumluregn
Copy link
Contributor Author

Closed with #4688.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.16.2
Development

Successfully merging a pull request may close this issue.

Fix for broken dialogs after opening the same one twice ckeditor/ckeditor4
4 participants
@f1ames @Comandeer @Dumluregn @CKEditorBot