Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview addon should use editor's "title" property for the title of the new window #4026

Closed
spacevoyager78 opened this issue May 6, 2020 · 3 comments · Fixed by #4915
Closed
Assignees
Labels
plugin:preview The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone

Comments

@spacevoyager78
Copy link

spacevoyager78 commented May 6, 2020

Type of report

Feature request

Provide description of the new feature

Currently, Preview addon uses its name for the title of the new windows that is create, as you can see in its source code: https://github.com/ckeditor/ckeditor4/blob/major/plugins/preview/plugin.js#L100
title = editor.lang.preview.preview,
However, since you can use print function to create pdf files via pdf printers or internal pdf function of chromium-based browsers, I think it should use title property of editor instance, so as to have a default pdf filename that resembles the editor title.
So, I propose that the above line in code should be changed from
title = editor.lang.preview.preview,
to
title = editor.title,

@spacevoyager78 spacevoyager78 added the type:feature A feature request. label May 6, 2020
@jacekbogdanski jacekbogdanski self-assigned this May 8, 2020
@jacekbogdanski
Copy link
Member

jacekbogdanski commented May 8, 2020

Indeed that makes sense, thanks @WiZaRD13 👍 As you already did some research on this topic, maybe you would like to propose PR for this improvement?

Also, note that print plugin also uses preview under the hood, so it probably would also profit from this improvement.

@jacekbogdanski jacekbogdanski added status:confirmed An issue confirmed by the development team. plugin:preview The plugin which probably causes the issue. labels May 8, 2020
@spacevoyager78
Copy link
Author

I'm sorry, I'm really ignorant about PR and the whole procedure, plus I don't have much time right now...

@CKEditorBot
Copy link
Collaborator

Closed in #4915

@CKEditorBot CKEditorBot added this to the 4.17.0 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:preview The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants