dialog.validate.functions incorrectly joins validator results

[bunglegrind]

Type of report

Bug

Provide detailed reproduction steps (if any)

just implement the sample code in the documentation

https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_dialog_validate.html#method-functions

Expected result

A validator composed by notEmpty and number

Actual result

A validator which always return true

Other details

Tested on 4.15.1 on Firefox latest version.

The sample code should be:

CKEDITOR.dialog.validate.functions(
    CKEDITOR.dialog.validate.notEmpty( ), //Note: no error message!
    CKEDITOR.dialog.validate.number( ) ,//Note: no error message!
    'error!'
);

The real problem is that in case of failed validation, the validation functions (validate.regex for instance) return the error message which is actually a truthy value in javascript (unless it's the empty string). They should return false: the current behavior is quite misleading.

At least, please update the sample code in the documentation.

btw, there are no tests related to dialog.validate in tests/plugin/dialog

[bunglegrind]

Or explicity check for boolean (=== true) in the following lines:

ckeditor4/plugins/dialog/plugin.js

Line 3251 in 5380706

passed = passed && functions[ i ]( value );

ckeditor4/plugins/dialog/plugin.js

Line 3253 in 5380706

passed = passed || functions[ i ]( value );

[f1ames]

Interesting find @bunglegrind, thanks for reporting. Indeed it looks like an issue in the code (and misleading documentation too). We will take a look on this one (and if there are any unintended consequences in the existing plugins).

[bunglegrind]

Well, you could start by updating the example in the docs. I spent one hour in order to discover what was going wrong...

[lukewhitmore]

I can confirm the same.

@bunglegrind - thanks for the suggestion of a workaround.

[CKEditorBot]

Closed in #5248