Incorrect conversion of HSL/HSLA values

[Comandeer]

Type of report

Bug

Provide detailed reproduction steps (if any)

1. Open browser console.
2. Go to https://jsfiddle.net/7Ljwqmtz/1/
3. Check console.

Expected result

Colors in the same console row should be the same.

Actual result

Colors are different. The second parameter changed from 50% to 0%.

Other details

• CKEditor version: 4.16.0

[Comandeer]

Another case:

hsla(123,0%,50%,0.5) → hsla(0,0%,50.19607843137255%,0.5)

[Comandeer]

Another case:

hsla( 123, 10%, 10%, 0.5 ) → hsla(120,0%,10%,0.5)

[Comandeer]

Ok, so there's a small issue… Different HSL values produce the same color. Therefore our conversion algorithm works correctly (despite one thing mentioned below). To avoid losing the real input data from HSL, we will probably need to save it alongside RGB ones.

And there's also a normal bug in our algorithm: saturation is rounded before multiplying it by 100. That means that it will be always 0 or 1, without any other value.

[CKEditorBot]

Closed in #4633