Fix incorrect HSL/HSLA conversion #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dumluregn
requested changes
Apr 22, 2021
|
Ok, I've updated API docs and slightly modified tests to also assert channels. |
…iginal format is also HSL/HSLA.
…itional info about types. Co-authored-by: Dariusz Jarzębski <d.jarzebski@cksource.com>
|
Rebased onto latest |
Dumluregn
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
Due to the issue mentioned in #4597 (comment) I've introduced additional data saved for HSL colors (hue, saturation and lightness) alongside the concept of color type.
Additionally I added rounding of lightness value and fixed the issue with saturation being always 0 or 1, due to incorrect rounding.
Which issues does your PR resolve?
Closes #4597.
Note: this PR is a bug fix, however it's targeted to
majoras already merged changes (#4599) introduced some tests that have incorrect values and this PR fixes it.