Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache key not applied everywhere #4761

Closed
TZanke opened this issue Jun 15, 2021 · 4 comments · Fixed by #4852 or #5003
Closed

Cache key not applied everywhere #4761

TZanke opened this issue Jun 15, 2021 · 4 comments · Fixed by #4852 or #5003
Assignees
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@TZanke
Copy link

TZanke commented Jun 15, 2021

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open browser with debug tools
  2. Open CKEditor demo page: https://ckeditor.com/ckeditor-4/demo/

Expected result

Every file should have a ?t=123 cache key.

tableselection.css?t=123

Actual result

At least some, like tableselection.css do not have a cache key.

tableselection.css

Other details

  • Browser: Chrome 90
  • OS: Suse 15.2
  • CKEditor version: "4.16.1 (Standard)"
  • Installed CKEditor plugins: "dialogui,dialog,a11yhelp,about,notification,button,toolbar,clipboard,textmatch,fakeobjects,link,autolink,undo,autoembed,basicstyles,blockquote,panelbutton,panel,floatpanel,colorbutton,colordialog,menu,contextmenu,copyformatting,elementspath,lineutils,widgetselection,widget,notificationaggregator,embedbase,embedsemantic,enterkey,entities,popup,filetools,filebrowser,floatingspace,listblock,richcombo,font,format,horizontalrule,htmlwriter,image,image2,indent,indentblock,indentlist,justify,list,liststyle,magicline,maximize,pastefromword,pastetext,preview,print,removeformat,resize,menubutton,scayt,showborders,sourcearea,sourcedialog,specialchar,stylescombo,tab,table,tabletools,tableresize,tableselection,uploadwidget,uploadfile,uploadimage,wysiwygarea"
@TZanke TZanke added the type:bug A bug. label Jun 15, 2021
@sculpt0r sculpt0r added core The issue is caused by the editor core code. size:S status:confirmed An issue confirmed by the development team. labels Jun 18, 2021
@sculpt0r
Copy link
Contributor

Hi @TZanke
Thank you for the report. I can confirm this issue.

Related issue (already closed) is: #731

So we have here:

  • BUG: not all editor assets are requested by the browser with timestamp, e.g. CSS assets added by plugins
  • TO VERIFY: does timestamp generator takes into account our config - so the User can add external resources e.g. CSS assets and change the timestamp without rebuilding the entire editor

@CKEditorBot
Copy link
Collaborator

Closed in #4852

@CKEditorBot CKEditorBot added this to the 4.16.3 milestone Aug 27, 2021
@jacekbogdanski jacekbogdanski modified the milestones: 4.16.3, 4.17.0 Sep 27, 2021
@jacekbogdanski jacekbogdanski modified the milestones: 4.17.0, 4.17.1 Nov 17, 2021
@jacekbogdanski
Copy link
Member

Unfortunately, we had to roll back this fix as it started to break relative CSS links. We will work on it for the next release.

@CKEditorBot
Copy link
Collaborator

Closed in #5003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
5 participants