Fix failing tests #127
Merged
Fix failing tests #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's huge different if spy was not called at all or it was called too many times
Back to global config verification in test
sculpt0r
force-pushed
the
t/124-fix-test
branch
from
1f53d25
to
9b6de22
Compare
jacekbogdanski
approved these changes
Dec 7, 2021
jacekbogdanski
requested changes
Dec 7, 2021
There was a problem hiding this comment.
I didn't notice it earlier but it looks like we lost 100% test coverage somehow. Could you take a look @sculpt0r ?
tests/integration.js
Outdated
|
|
||
| deleteCkeditorScripts(); | ||
|
|
||
| return createComponent( { editorUrl: basePath + 'ckeditor.js' } ).then( (comp) => { |
There was a problem hiding this comment.
Suggested change
| return createComponent( { editorUrl: basePath + 'ckeditor.js' } ).then( (comp) => { | |
| return createComponent( { editorUrl: basePath + 'ckeditor.js' } ).then( ( comp ) => { |
tests/integration.js
Outdated
| const scripts = Array.from( document.querySelectorAll( 'script' ) ); | ||
| const ckeditorScripts = scripts.filter( scriptElement => { | ||
| return scriptElement.src.indexOf( 'ckeditor.js' ) > -1; | ||
| }); |
There was a problem hiding this comment.
Suggested change
| }); | |
| } ); |
|
The gap in coverage appears due to the fact - that now there is no editor created with empty config. Because I added |
|
|
It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days. |
github-actions
bot
added
the
stale
sculpt0r
removed
the
stale
jacekbogdanski
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I started with defensive
ifon the fragileCKEDITORin the observer (main repository). However, not all tests passed.The most damaged makes setup editor from CDN via
editorUrlprops. So I moved it to the last position, so no other tests will fail because of it: 844da89I have a problem with not incoming events from the main editor code, like
readyand I decided that I change an assertion, so it shows if the event was invoked at all, rather than verify only if it was one time. Because no calls of the spy in the test - means that some event wasn't raised at a deep level, whereas multiple calls tell us about problems in integration commons: c3fc2a1Based debug in karma run, I found that the failing test
should use correct CKEDITOR buildtry to load some assets from the different origin that it was set viaeditorUrl. And it appears that during the test we are deletingwindow.CKEDITORbut there are still scripts added via 'namespaceloader'. So I decided to remove allckeditor.jsscripts-like along with deleting globalwindow.CKEDITOR. That fixes the last test assertion problem: fdb6de3 However, I'm still thinking, that if you load CKE4 from the CDN viaeditorUrland then, you checkeditorInstance.config.basePath- it's different. It has good parts, but that may be something worth checking with ckeditor/ckeditor4#4761.I was able to fix the issue with
MutationObserverin vue tests, thanks to also new config option: https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_config.html#cfg-observableParent It tells the observer, which node should be checked and in case of changes - determine if there is an CKE4 instance inside. If we provide an immutable element, then observer callback will never be run: a745009Finally, I have to adjust the code for IE 馃槩 : 9b6de22
Closes #124