Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easy Image upload via toolbar button not working #5234

Closed
Comandeer opened this issue Jun 7, 2022 · 1 comment · Fixed by #5250
Closed

Easy Image upload via toolbar button not working #5234

Comandeer opened this issue Jun 7, 2022 · 1 comment · Fixed by #5250
Assignees
@KarolDawidziuk
Labels
plugin:easyimage The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.19.1

Comments

@Comandeer
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open https://ckeditor.com/docs/ckeditor4/latest/examples/easyimage.html
  2. Press Easy Image toolbar button.
  3. Select any image.

Expected result

Image is inserted into the editor and uploaded

Actual result

Nothing happens.

Other details

  • Browser: all
  • OS: all
  • CKEditor version: 4.17.2+
  • Installed CKEditor plugins: easyimage, clipboard

Bisect shown that the first bad commit is 23b6f60.

It seems that the new way of detecting file upload does not correctly detect the Easy Image upload. It's probably connected with the fact that we create a synthetic paste event that lacks Files content type.
@Comandeer Comandeer added type:bug A bug. status:confirmed An issue confirmed by the development team. regression This issue is a regression. plugin:easyimage The plugin which probably causes the issue. size:S labels Jun 7, 2022
@KarolDawidziuk KarolDawidziuk self-assigned this Jun 21, 2022
@KarolDawidziuk KarolDawidziuk mentioned this issue Jun 23, 2022
Merged
3 tasks
sculpt0r added a commit that referenced this issue Jun 29, 2022
@sculpt0r
Add changelog entry for #5234
5ace824
@CKEditorBot
Copy link
Collaborator

Closed in #5250

@CKEditorBot CKEditorBot added this to the 4.19.1 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KarolDawidziuk KarolDawidziuk

Labels
plugin:easyimage The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.19.1
Development

Successfully merging a pull request may close this issue.

Fix easy image upload button ckeditor/ckeditor4
3 participants
@Comandeer @KarolDawidziuk @CKEditorBot