Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to indicate the language of styles #5410

Closed
Comandeer opened this issue Jan 26, 2023 · 0 comments · Fixed by #5474
Closed

Add ability to indicate the language of styles #5410

Comandeer opened this issue Jan 26, 2023 · 0 comments · Fixed by #5474
Assignees
Labels
accessibility Issue related to accessibility. plugin:stylescombo The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:feature A feature request.

Comments

@Comandeer
Copy link
Member

Comandeer commented Jan 26, 2023

Type of report

Feature request

Provide description of the new feature

Currently, styles for the "Styles" dropdown are configured via the config.styleSet config variable. However, it could result in a situation when defined styles are in a different language than the rest of the editor's UI. This could pose an issue for screen readers which will read the name of a style with the wrong pronunciation rules.

Due to that, it'd be a good idea to provide an ability to indicate the language of the style name, e.g.:

config.stylesSet = [
    { name: 'Strong Emphasis', language: 'en', element: 'strong' },
    { name: 'Wyróżnienie', language: 'pl', element: 'em' },
    ...
];

This will result in the options in the "Styles" combobox with the appropriate lang attribute.

The alternative approach could allow the translation of the styles names, e.g. by providing the style_<name> entries in the lang files of the stylescombo plugin (see #864).

@Comandeer Comandeer added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:stylescombo The plugin which probably causes the issue. accessibility Issue related to accessibility. labels Jan 26, 2023
@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Jan 27, 2023
@KarolDawidziuk KarolDawidziuk self-assigned this Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. plugin:stylescombo The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants