Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove italic style from TextPartLanguage feature. #5455

Closed
vladsolntsev opened this issue Apr 5, 2023 · 2 comments
Closed

Remove italic style from TextPartLanguage feature. #5455

vladsolntsev opened this issue Apr 5, 2023 · 2 comments
Labels
resolution:invalid Not a valid issue (wrong request type, support requests, etc).

Comments

@vladsolntsev
Copy link

Type of report

Task

Provide description of the task

Remove the default CSS styling of the span[lang]

Other details

This was just implemented in Ckeditor5 here - ckeditor/ckeditor5#13804.

I think that this makes sense, as setting the italic font-style on the selected language is not intuitive at all, and makes it difficult for editors to know what part of the text is really in italic and what part is just a translated language.

@vladsolntsev vladsolntsev added the type:task Any other issue (refactoring, typo fix, etc). label Apr 5, 2023
@github-actions
Copy link

It's been a while since we last heard from you. We are marking this issue as stale due to inactivity. Please provide the requested feedback or the issue will be closed after next 7 days.

@github-actions github-actions bot added the stale The issue / PR will be closed within the next 7 days of inactivity. label Apr 13, 2023
@KarolDawidziuk
Copy link
Contributor

Hi @vladsolntsev and sorry for the late reply.

As the CKEditor 4 allows you to modify styles placed inside the contents.css file in several different ways, there is no need to remove this.
To change it you can use one of the configuration options:

I'm closing this report.

@KarolDawidziuk KarolDawidziuk added resolution:invalid Not a valid issue (wrong request type, support requests, etc). and removed type:task Any other issue (refactoring, typo fix, etc). stale The issue / PR will be closed within the next 7 days of inactivity. labels Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:invalid Not a valid issue (wrong request type, support requests, etc).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants