Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language): remove default italic style for language selection #5456

Closed
wants to merge 1 commit into from

Conversation

vladsolntsev
Copy link

What is the purpose of this pull request?

To remove the default italic style for selected language text.

This was just approved for Ckeditor5 here (ckeditor/ckeditor5#13804).

Does your PR contain necessary tests?

Only CSS is changed.

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

What changes did you make?

Remove the italic styling on span[lang] attribute.

Which issues does your PR resolve?

Closes #5455

@KarolDawidziuk
Copy link
Contributor

Hi @vladsolntsev and thank you for the PR.

I'm closing this PR because there is no need to remove this. You can use one of the available editor configuration options for that. For more information please see: #5455 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove italic style from TextPartLanguage feature.
2 participants