Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element/Image drag to move within table is no longer available #547

Closed
KrisJohnson opened this issue Jun 21, 2017 · 5 comments · Fixed by #4951
Closed

Element/Image drag to move within table is no longer available #547

KrisJohnson opened this issue Jun 21, 2017 · 5 comments · Fixed by #4951
Assignees
Labels
plugin:image The plugin which probably causes the issue. plugin:image2 The plugin which probably causes the issue. plugin:tableselection The plugin which probably causes the issue. plugin:widget The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@KrisJohnson
Copy link

BUG

Element/Image drag to move within table is no longer available

Steps to reproduce

  1. Insert multi-cell table
  2. Insert image into a cell
  3. Drag image to another cell. (This does not work).
  4. Add text to cell.
  5. Select text and move to another cell. (This does not work).

I expected the image or text to move to another cell.

Actual result is the cell itself is selected

I was able to reproduce with the demos on CKEditor.com

  • Browser: Chrome,IE
  • OS: Windows
@beatadelura beatadelura self-assigned this Jun 29, 2017
@beatadelura
Copy link
Contributor

beatadelura commented Jun 29, 2017

It seems problem occurred with release 4.7.0 CKEditor version and it's related to tableselection plugin. Everything works fine with 4.6.0 CKEditor version, I did tests on macOS (Chrome, Safari, Firefox) and Windows (Edge, IE11, Chrome, Firefox).


⚠️ Note: Regression in version 4.7.0

@beatadelura beatadelura added plugin:tableselection The plugin which probably causes the issue. type:bug A bug. regression This issue is a regression. status:confirmed An issue confirmed by the development team. labels Jun 29, 2017
@beatadelura beatadelura removed their assignment Jun 29, 2017
@lazka
Copy link

lazka commented Apr 25, 2019

In case anyone finds this: disabling the "tableselection" plugin makes dragging work again.

@f1ames
Copy link
Contributor

f1ames commented Apr 25, 2019

It could be related to #2235. I wonder if #3059 will fix this 🤔

@f1ames f1ames added the plugin:image The plugin which probably causes the issue. label Apr 25, 2019
@Dumluregn
Copy link
Contributor

#3059 doesn't fix it. What is more the issue is reproducible also with Enhanced Image plugin, so using drag handler doesn't help. A way to solve this could be disabling tableselection if there is only image in current selection (because you click on image before you start dragging it), but it may lead to some unexpected behaviours.

@CKEditorBot
Copy link
Collaborator

Closed in #4951

@CKEditorBot CKEditorBot added this to the 4.17.2 milestone Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:image The plugin which probably causes the issue. plugin:image2 The plugin which probably causes the issue. plugin:tableselection The plugin which probably causes the issue. plugin:widget The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
9 participants