Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut doesn't work inside the nested table #787

Closed
Mgsy opened this issue Aug 14, 2017 · 2 comments · Fixed by #792
Closed

Cut doesn't work inside the nested table #787

Mgsy opened this issue Aug 14, 2017 · 2 comments · Fixed by #792
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone
4.8.0

Comments

@Mgsy
Copy link
Member

Mgsy commented Aug 14, 2017

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Create the table.
  2. Put the caret at the cell.
  3. Create the nested table.
  4. Type something in two different cells (inside the nested table).
  5. Select these cells.
  6. Press Ctrl + X.

Expected result

Text should be cut.

Actual result

The selection disappears, text wasn't removed, but cells were copied to the clipboard.

GIF

bug_cke4

Other details

  • Browser: All browsers
  • OS: Windows 10
  • CKEditor version: 4.7.2
@Mgsy Mgsy added the type:bug A bug. label Aug 14, 2017
@mlewand mlewand added status:confirmed An issue confirmed by the development team. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels Aug 14, 2017
@mlewand mlewand added this to the 4.7.3 milestone Aug 14, 2017
@mlewand mlewand added the plugin:tableselection The plugin which probably causes the issue. label Aug 14, 2017
@Comandeer Comandeer mentioned this issue Aug 16, 2017
Merged
2 tasks
@Comandeer
Copy link
Member

Actually this issue is not connected with tableselection plugin, it's more generic issue connected with editable.extractHtmlFromRange method and it's reproducible in Firefox (as it's the only browser with multiple-range selection) even in older versions than 4.7.0.

@mlewand mlewand removed the plugin:tableselection The plugin which probably causes the issue. label Aug 16, 2017
@mlewand mlewand modified the milestones: 4.8.0, 4.7.3 Sep 5, 2017
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Sep 5, 2017
@mlewand
Copy link
Contributor

mlewand commented Sep 5, 2017

We won't be able to include this release into upcoming release. I'm putting it to 4.8.0, but if we'll be adding a any minor release in between it's perfectly fine to move it to any sooner release.

@f1ames f1ames mentioned this issue Sep 13, 2017
Open
@f1ames f1ames added target:major Any docs related issue that should be merged into a major branch. and removed target:minor Any docs related issue that can be merged into a master or major branch. labels Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

Cutting from nested table ckeditor/ckeditor4
4 participants
@f1ames @Comandeer @mlewand @Mgsy