Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .mailmap from builder output #10

Merged
merged 1 commit into from
Nov 10, 2012
Merged

Remove .mailmap from builder output #10

merged 1 commit into from
Nov 10, 2012

Conversation

AlfonsoML
Copy link
Contributor

Fix for http://dev.ckeditor.com/ticket/9586

This Github thing is still more complex than I expected, let's hope that this is the final step

Reinmar added a commit that referenced this pull request Nov 10, 2012
Remove .mailmap from builder output.
@Reinmar Reinmar merged commit c0e1363 into ckeditor:master Nov 10, 2012
@Reinmar
Copy link
Member

Reinmar commented Nov 10, 2012

Thanks Alfonso for this patch :). Small advice for the future - it's better to open pull requests for specific branch, not master. Then you'll be able to e.g. open multiple pull requests. You can also follow our naming convention, so in this case branch would be named t/9586 (ticket branch).

@AlfonsoML
Copy link
Contributor Author

Thank you.
I have a lot to learn about Git so any advice (little by little) is welcome. And now that I've started working on it I might be able to understand things that previously were just confusing new concepts.
I've created a new pull following (or at least I tried) your advice, and I guess that branches here means something much simpler that what I was used to and that I was afraid to do for simple things like these simple patches.

@Reinmar
Copy link
Member

Reinmar commented Nov 12, 2012

Yep - if you haven't got Git experience before, then you'll have a lot of fun discovering how many times it's better than the old SVN :).

You've done the new pull request exactly like it should be done. Thanks :).

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013
mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013
mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013
mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013
mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants