Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with textwatcher throttle invalid selection #2376

Closed
wants to merge 17 commits into from
Closed

Fixed issue with textwatcher throttle invalid selection #2376

wants to merge 17 commits into from

Commits on Sep 7, 2018

  1. Fixed throttle called out of sync.

    @jacekbogdanski @mlewand
    jacekbogdanski authored and mlewand committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    0a4261a View commit details
    Browse the repository at this point in the history

  2. Fixed unit tests.

    @jacekbogdanski @mlewand
    jacekbogdanski authored and mlewand committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    dd935ca View commit details
    Browse the repository at this point in the history

  3. Added unit test.

    @jacekbogdanski @mlewand
    jacekbogdanski authored and mlewand committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    c8c1644 View commit details
    Browse the repository at this point in the history

  4. Added manual test.

    @jacekbogdanski @mlewand
    jacekbogdanski authored and mlewand committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    f91628c View commit details
    Browse the repository at this point in the history

  5. Rectored manual tests.

    @jacekbogdanski @mlewand
    jacekbogdanski authored and mlewand committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    95a7287 View commit details
    Browse the repository at this point in the history

  6. Added changelog entry.

    @jacekbogdanski @mlewand
    jacekbogdanski authored and mlewand committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    d159179 View commit details
    Browse the repository at this point in the history

  7. Adjusted changelog entry.

    @mlewand
    mlewand committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    8586430 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2018

  1. Code style: corrected JS code in manual test.

    @mlewand
    mlewand committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    3ebcdd4 View commit details
    Browse the repository at this point in the history

  2. Reverted changes in textwatcher, and simplified the fix.

    @mlewand
    mlewand committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    14b7cf8 View commit details
    Browse the repository at this point in the history

  3. Refactoring: removed duplicated code by replacing it with _getRange c… 

    …all.
    @mlewand
    mlewand committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    2e25626 View commit details
    Browse the repository at this point in the history

  4. Refactoring: testTextMatch no longer needs to take an argument, as it… 

    … needs to refresh it afterwards anyways due to #2373.
    @mlewand
    mlewand committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    b5e9817 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. Unmatching with no selection.

    @jacekbogdanski
    jacekbogdanski committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    c79e60f View commit details
    Browse the repository at this point in the history

  2. Tests: covered unmatching with no selection.

    @jacekbogdanski
    jacekbogdanski committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    c36da9d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. Tests: fixed unit test with no selection and added TC that ensures th… 

    …at no unmatch event is fired if text was not matched.
    @mlewand
    mlewand committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    c4bcca3 View commit details
    Browse the repository at this point in the history

  2. Fixed an issue where text watcher could fire unmatched event when no … 

    …text was matched before.
    @mlewand
    mlewand committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    c8bca2a View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Ignored tests on mobile.

    @jacekbogdanski
    jacekbogdanski committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    963326e View commit details
    Browse the repository at this point in the history

  2. Simplified unit test.

    @jacekbogdanski
    jacekbogdanski committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    9621071 View commit details
    Browse the repository at this point in the history