Replace deprecated 'arguments.callee' #2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ames
suggested changes
Mar 4, 2019
|
Rebased on latest |
f1ames
suggested changes
Mar 5, 2019
There was a problem hiding this comment.
There is still one .callee used in the code - https://github.com/ckeditor/ckeditor-dev/blob/4a9cd5e67e1d5da7406f62bc2ae01a536a008508/adapters/jquery.js#L163.
Please, remember that when PR targets major version, the changelog entry should be placed under upcoming major section in CHANGES.md (here it is 4.12, and it always follows the A.B convention). For minor it should be under minor section (which is now 4.11.4, and follows the A.B.C convention). I fixed it in 419f97b.
f1ames
suggested changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Replacement of deprecated code.
Does your PR contain necessary tests?
Tests already in place.
This PR contains
What changes did you make?
Replaced 'arguments.callee' in 5 files, mostly using named function expressions.
Closes #2741.