Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKEDITOR.tools improvements #3125

Merged
merged 19 commits into from Jun 15, 2019
Merged

CKEDITOR.tools improvements #3125

merged 19 commits into from Jun 15, 2019

Conversation

jacekbogdanski
Copy link
Member

What is the purpose of this pull request?

New feature/Bug fix

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

Closes #3120
Closes #3123

@jacekbogdanski
Copy link
Member Author

Updated according to discussion #3123

@f1ames f1ames self-requested a review June 14, 2019 14:01
@f1ames f1ames self-assigned this Jun 14, 2019
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two test suites are red on IE8:

image

image

CHANGES.md Outdated Show resolved Hide resolved
core/tools.js Show resolved Hide resolved
core/tools.js Show resolved Hide resolved
@jacekbogdanski
Copy link
Member Author

jacekbogdanski commented Jun 14, 2019

Seems like IE8 cache played with me a bit when testing this PR. Should be fine now.

@jacekbogdanski jacekbogdanski removed their assignment Jun 14, 2019
@f1ames f1ames self-assigned this Jun 15, 2019
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@f1ames f1ames merged commit 4d72da5 into major Jun 15, 2019
@CKEditorBot CKEditorBot deleted the t/3123 branch June 15, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKEDITOR.tools.object helper methods improvements CKEDITOR.tools.createClass is unable to overwrite members
2 participants