Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference about the old parameter 'internal' parameter in 'setData()' method #3420

Merged
merged 2 commits into from Mar 26, 2020

Conversation

Dumluregn
Copy link
Contributor

@Dumluregn Dumluregn commented Sep 16, 2019

What is the purpose of this pull request?

To fix inconsistent API Docs about setData() method.
It was caused by maintaining backward compatibility, as mentioned above:

ckeditor4/core/editor.js

Lines 1106 to 1108 in 52ec0b1

* Note: In **CKEditor 4.4.2** the signature of this method has changed. All arguments
* except `data` were wrapped into the `options` object. However, backward compatibility
* was preserved and it is still possible to use the `data, callback, internal` arguments.
Still, as using internal parameter is valid, I added reference to it.

Closes #3417.

@Dumluregn Dumluregn changed the title Add reference about the old parameter. Add reference about the old parameter 'internal' parameter in 'setData()' method Sep 16, 2019
@f1ames f1ames self-requested a review March 26, 2020 08:32
@f1ames f1ames self-assigned this Mar 26, 2020
@f1ames f1ames changed the base branch from major to master March 26, 2020 08:32
@f1ames
Copy link
Contributor

f1ames commented Mar 26, 2020

Rebased and retargeted onto latest master.

Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@f1ames f1ames merged commit 5e37e65 into master Mar 26, 2020
@CKEditorBot CKEditorBot deleted the t/3417 branch March 26, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKEDITOR.editor#setData() docs are incorrect
2 participants