Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incorrect recognition of Excel content #3641

Merged
merged 5 commits into from
Dec 2, 2019
Merged

Fix for incorrect recognition of Excel content #3641

merged 5 commits into from
Dec 2, 2019

Conversation

Comandeer
Copy link
Member

@Comandeer Comandeer commented Nov 11, 2019

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What is the proposed changelog entry for this pull request?

* [#3586](https://github.com/ckeditor/ckeditor4/3586): Fixed: content pasted from Excel is not recognised by [Paste from Word](https://ckeditor.com/cke4/addon/pastefromword).

What changes did you make?

I've forced usage of raw clipboard data in canHandle method of PfW paste handler.

Closes #3586.

@f1ames f1ames self-requested a review November 25, 2019 15:56
@f1ames f1ames self-assigned this Nov 25, 2019
@f1ames
Copy link
Contributor

f1ames commented Nov 26, 2019

Rebased onto latest master.

Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Two minor tests issues to check:

All unit tests are passing on Safari, however manual test fails and I can see background-color is present in clipboard data:

image

I thought it's some known issue but I see we don't have anything reported 🤔 Ok, it looks like separate issue reported in #2609, could you confirm @Comandeer?


And some failing tests on Edge again, but I suppose its related to the instability we have (looks like #3539 (review)):

image

The problem is, these are always red for me now. Could you check how it works for you @Comandeer?

@Comandeer
Copy link
Member Author

Ok, it looks like separate issue reported in #2609, could you confirm @Comandeer?

Yes, I ignored manual test in IE 8 and Safari.

Could you check how it works for you @Comandeer?

They pass for me on local machine. However on remote one they are more troublesome, yet I forced them to pass by manual refreshing the page several times. Seems like Edge has some serious issues with cache 🤔

@f1ames
Copy link
Contributor

f1ames commented Dec 2, 2019

Rebased onto latest master.

Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@f1ames f1ames merged commit 2f7937f into master Dec 2, 2019
@CKEditorBot CKEditorBot deleted the t/3586 branch December 2, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants