-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for incorrect recognition of Excel content #3641
Conversation
Rebased onto latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Two minor tests issues to check:
All unit tests are passing on Safari, however manual test fails and I can see background-color
is present in clipboard data:
I thought it's some known issue but I see we don't have anything reported 🤔 Ok, it looks like separate issue reported in #2609, could you confirm @Comandeer?
And some failing tests on Edge again, but I suppose its related to the instability we have (looks like #3539 (review)):
The problem is, these are always red for me now. Could you check how it works for you @Comandeer?
Yes, I ignored manual test in IE 8 and Safari.
They pass for me on local machine. However on remote one they are more troublesome, yet I forced them to pass by manual refreshing the page several times. Seems like Edge has some serious issues with cache 🤔 |
Rebased onto latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What is the proposed changelog entry for this pull request?
What changes did you make?
I've forced usage of raw clipboard data in
canHandle
method of PfW paste handler.Closes #3586.