T/17027 Commands event data should be initialized as an empty object #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
suggested changes
May 12, 2017
tests/core/command/events.js
Outdated
|
|
||
| this.editor.once( 'afterCommandExec', function( evt ) { | ||
| assert.areSame( beforeExecData, evt.data.commandData, 'The same object is passed to afterCommandExec.' ); | ||
| }, null, null, 1 ); |
There was a problem hiding this comment.
No need to set the priority.
tests/core/command/events.js
Outdated
| }, null, null, 1 ); | ||
|
|
||
| this.editor.addCommand( 'dataFlow', { | ||
| exec: function() { |
There was a problem hiding this comment.
Since we're testing beforeExecData in beforeCommandExec and afterCommandExec it would make sense to test it in exec too for the completeness.
tests/core/command/events.js
Outdated
| this.editor.once( 'beforeCommandExec', function( evt ) { | ||
| beforeExecData = evt.data.commandData; | ||
|
|
||
| assert.isObject( beforeExecData, 'Event data is initialized as an empty object.' ); |
There was a problem hiding this comment.
Don't put dots at the end of assertion msg.
|
I added these minor changes while reviewing, so R+. |
mlewand
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if command is not passed an object as a second argument, it fall backs to undefined, causing the unability to pass anything from command to afterCommandExec event.
This change is intended to introduce empty object as a default value for command's event data.