Fixed breaking code when creating and destroying the editors #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jsfiddle.net/Z4dBN/4/
This is the setup I've encountered the JS errors with and my patch will get rid of those errors. It's a quick patch and I haven't dug deeper into why errors happen, but I know for sure it's because I'm destroying and attaching editors very quickly. During this some events are lagging a bit behind and the editor.element reference is already gone when some of the events are triggered.
I don't know why the editor doesn't show up on the fiddle, it does on my computer, but I think this fiddle still points out the problem.
If you want me to change the patch so that the element reference is checked elsewhere, I'm more than happy to do so.