#17052 Error on scroll while selecting nested table #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
suggested changes
Jun 5, 2017
|
|
||
| 1. Open console. | ||
| 2. Select cells inside nested table. | ||
| 3. Without releasing mouse button, move pointer to the bottom edge of the editor to cause scrolling down to the end of the editor. |
There was a problem hiding this comment.
Add a note that for Edge/IE it acts differently, as it does not scroll.
|
Ok, I've prepared unit test and added note about Edge. I've also changed references to ticket number. |
mlewand
approved these changes
Jun 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was caused by the fact that mouse handler is fired also on
mousemoveand scrolling selects cell outside the nested table. Simple check if the newly selected cell is still inside the original table should do the trick.Closes #493.