Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep stylesLoaded out of global context #4194

Closed
wants to merge 2 commits into from
Closed

Keep stylesLoaded out of global context #4194

wants to merge 2 commits into from

Commits on Aug 7, 2020

  1. Keep stylesLoaded out of global context 

    Moved the dialog plugin's stylesLoaded variable into the IIFE to prevent the stylesLoaded variable from being included (and editable) in the global context. This also required moving the "CKEDITOR.plugins.add( 'dialog', { ..." call into the IIFE - where it should have been to begin with.
    @swiftMessenger
    swiftMessenger committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    eb7a7cf View commit details
    Browse the repository at this point in the history

  2. Moved comment 

    Moved comment out of IIFE back to where it belongs
    @swiftMessenger
    swiftMessenger committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    7143b46 View commit details
    Browse the repository at this point in the history