New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 4282 - During the uploaded scripts check the scriptLoader checks only 50 per cent of them and doesn’t execute callback #4283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution @aldoom!
Your pull request is missing tests, see our Contributing Code guide for more details. If you have any issues adding them, feel free to reach out so we can assist.
You may also take a look at existing scriptLoader
tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix seems to work correctly, good job!
There are only some small issues:
- Could you move the unit test to the file dedicated to script loader (
tests/core/scriptloader.js
)? - Could you rebase the branch onto
master
and target it tomaster
(instead ofmajor
)?
Done |
…hecks only 50 per cent of them and doesn’t execute callback.
…hecks only 50 per cent of them and doesn’t execute callback. + Test
…hecks only 50 per cent of them and doesn’t execute callback
Rebased onto latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just slightly reworked unit tests. Also run all core tests for all the browsers and it looks good too 👍
LGTM 👍 Thanks @aldoom for contribution 👏 🎉
Fix issue 4282 - During the uploaded scripts check the scriptLoader checks only 50 per cent of them and doesn’t execute callback.
What is the purpose of this pull request?
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
Give an overview…
Which issues does your PR resolve?
Closes #4282.