Skip to content

Commit

Permalink
Merge pull request #183 from ckeditor/i/182
Browse files Browse the repository at this point in the history
Other: Bumped up all internals to match the Angular@10 ecosystem. Bumped up peer dependencies and dependencies of the library - to Angular>=9.  Building an Angular app with the `ckeditor5-angular` library on production with sourcemaps turned on will no longer throw errors. Closes #182. Closes #194.

BREAKING CHANGE: Angular<9 will not work with the new `ckeditor5-angular` library anymore (it's mostly connected with an update of TypeScript to version TS 4.0, which produces declaration files incompatible with the previous TypeScript versions used by older versions of Angular).
  • Loading branch information
ma2ciek committed Oct 15, 2020
2 parents cc716a5 + 85c9365 commit 012c06c
Show file tree
Hide file tree
Showing 22 changed files with 10,250 additions and 9,502 deletions.
7 changes: 7 additions & 0 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"aot": true,
"outputPath": "dist/ckeditor5-angular",
"index": "src/index.html",
"main": "src/main.ts",
Expand All @@ -30,6 +31,12 @@
},
"configurations": {
"production": {
"budgets": [
{
"type": "anyComponentStyle",
"maximumWarning": "6kb"
}
],
"fileReplacements": [
{
"replace": "src/environments/environment.ts",
Expand Down
4 changes: 2 additions & 2 deletions e2e/protractor.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ exports.config = {
},
onPrepare() {
require( 'ts-node' ).register( {
project: require( 'path' ).join( __dirname, './tsconfig.e2e.json' )
project: require( 'path' ).join( __dirname, './tsconfig.json' )
} );
jasmine.getEnv().addReporter( new SpecReporter( { spec: { displayStacktrace: true } } ) );
},
useAllAngular2AppRoots: true,
useAllAngular2AppRoots: true
};
File renamed without changes.
Loading

0 comments on commit 012c06c

Please sign in to comment.