Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typings doesn't compile in TS in Angular@5 #172

Closed
ma2ciek opened this issue Mar 4, 2020 · 0 comments · Fixed by #173
Closed

Added typings doesn't compile in TS in Angular@5 #172

ma2ciek opened this issue Mar 4, 2020 · 0 comments · Fixed by #173
Assignees
Labels
Milestone

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Mar 4, 2020

Being concrete this line:

on( event: string, callback: ( ...args: any ) => any ): void;

should be changed to the following:

on( event: string, callback: ( ...args: any[] ) => any ): void;

to make the old TS compiler happy.

Sadly, the package builder which should compile packages working with Angular@5 can't find such mistakes.

@ma2ciek ma2ciek added this to the iteration 30 milestone Mar 4, 2020
@ma2ciek ma2ciek self-assigned this Mar 4, 2020
@ma2ciek ma2ciek changed the title Added typings doesn't compile in TS in Angular@5 Added typings doesn't compile in TS present in Angular@5 Mar 4, 2020
@ma2ciek ma2ciek changed the title Added typings doesn't compile in TS present in Angular@5 Added typings doesn't compile in TS in Angular@5 Mar 4, 2020
ma2ciek added a commit that referenced this issue Mar 4, 2020
Fix: Fixed typings for `Watchdog` to make old TS compilers happy. Closes #172.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant