Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ESLint and add pre-commit hook #94

Closed
ma2ciek opened this issue Apr 17, 2019 · 0 comments · Fixed by #104
Closed

Switch to ESLint and add pre-commit hook #94

ma2ciek opened this issue Apr 17, 2019 · 0 comments · Fixed by #104
Milestone
iteration 24

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Apr 17, 2019 •
edited
Loading

TS switches from TSLint to ESLint - palantir/tslint#4534, https://github.com/typescript-eslint/typescript-eslint. We can take an occasion and extend our eslint-config-ckeditor5 with some custom TS rules to align code to other CKEditor 5 repositories.
@ma2ciek ma2ciek added this to the backlog milestone Apr 17, 2019
@ma2ciek ma2ciek changed the title Switch to eslint and add pre-commit hook Switch to ESLint and add pre-commit hook Apr 17, 2019
@ma2ciek ma2ciek mentioned this issue May 12, 2019
Merged
@ma2ciek ma2ciek modified the milestones: backlog, iteration 24 May 13, 2019
pomek added a commit that referenced this issue May 13, 2019
@pomek
Merge pull request #104 from ckeditor/t/94
f5e63c3 
Internal: Switched from TSLint to ESLint, added a pre-commit hook. Closes #94.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
iteration 24
Development

Successfully merging a pull request may close this issue.

Switch from TSLint to ESLint, add a pre-commit hook ckeditor/ckeditor5-angular
1 participant
@ma2ciek