Other: Detach LiveRange used to apply inline auto format.

ckeditor · Oct 17, 2017 · bd68e72 · bd68e72
1 parent f402607
commit bd68e72
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/inlineautoformatengine.js b/src/inlineautoformatengine.js
@@ -195,6 +195,9 @@ export default class InlineAutoformatEngine {
 				// Apply format.
 				formatCallback( fixBatch, validRanges );
 
+				// Detach ranges used to apply Autoformat. Prevents memory leaks. #39
+				rangesToFormat.forEach( range => range.detach() );
+
 				// Remove delimiters.
 				for ( const range of rangesToRemove ) {
 					fixBatch.remove( range );

diff --git a/tests/inlineautoformatengine.js b/tests/inlineautoformatengine.js
@@ -141,6 +141,9 @@ describe( 'InlineAutoformatEngine', () => {
 		it( 'should detach removed ranges', () => {
 			const detachSpies = [];
 			const callback = fixBatch => testUtils.sinon.stub( fixBatch, 'remove' ).callsFake( saveDetachSpy );
+			testUtils.sinon.stub( editor.document.schema, 'getValidRanges' )
+				.callThrough()
+				.callsFake( ranges => ranges.map( saveDetachSpy ) );
 
 			new InlineAutoformatEngine( editor, /(\*)(.+?)(\*)/g, callback ); // eslint-disable-line no-new
 
@@ -150,8 +153,8 @@ describe( 'InlineAutoformatEngine', () => {
 				doc.batch().insert( doc.selection.getFirstPosition(), '*' );
 			} );
 
-			// There should be two ranges removed.
-			expect( detachSpies ).to.have.length( 2 );
+			// There should be two removed ranges and one range used to apply autoformat.
+			expect( detachSpies ).to.have.length( 3 );
 
 			for ( const spy of detachSpies ) {
 				testUtils.sinon.assert.calledOnce( spy );