This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Fix: The value of the AttributeCommand is taken from the first allowed node #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Jun 29, 2018
src/attributecommand.js
Outdated
| const ranges = Array.from( selection.getRanges() ); | ||
|
|
||
| if ( selection.isBackward ) { | ||
| ranges.reverse(); |
There was a problem hiding this comment.
Checking range direction is removed.
pjasiun
reviewed
Jun 29, 2018
src/attributecommand.js
Outdated
| @@ -41,7 +41,7 @@ export default class AttributeCommand extends Command { | |||
| * Flag indicating whether the command is active. The command is active when the | |||
| * {@link module:engine/model/selection~Selection#hasAttribute selection has the attribute} which means that: | |||
| * | |||
| * * If the selection is not empty – That it starts in a text (or another node) which has the attribute set. | |||
| * * If the selection is not empty – That the first node in the selection that allows the attribute has the attribute set. | |||
There was a problem hiding this comment.
the selection that allows the attribute has the attribute set
Something is wrong in this sentence.
pjasiun
reviewed
Jun 29, 2018
src/attributecommand.js
Outdated
| * Checks the attribute value of the first node in the selection that allows the attribute. | ||
| * For the collapsed selection returns the selection attribute. | ||
| * | ||
| * **Note** Selection direction is taken into consideration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: The value of the
AttributeCommandis taken from the first allowed node. Closes ckeditor/ckeditor5#5548.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.