This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Marked basic style attributes with the AttributeProperties#isFormatting property #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sFormatting property.
|
This PR uses the editor.model.schema.setAttributeProperties() method which does not exist. The result is that I'm unable to build CKEditor from source. |
|
@mcrapts you should either use stable release tags or latest |
|
I see, you're right Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Marked basic style attributes as a formatting using the
AttributeProperties#isFormattingproperty. Closes ckeditor/ckeditor5#1664.Additional information
There are 2 more pull requests related with this in respective repositories.
All The PRs are referenced in ckeditor/ckeditor5#1664.