Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the block quote feature #3311

Closed
Reinmar opened this issue Feb 9, 2017 · 5 comments · Fixed by ckeditor/ckeditor5-block-quote#5
Closed

Implement the block quote feature #3311

Reinmar opened this issue Feb 9, 2017 · 5 comments · Fixed by ckeditor/ckeditor5-block-quote#5
Assignees
Labels
package:block-quote type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 9, 2017

In #393 we discussed the need to have two separate quote features – message quote and external quotes.

First, we'll work on the message quote as the easier and more general one.

EDIT: Upon further discussions, we identified 3 different types of quotes – block, message and pulled quotes. We also understood that the simplest of them, on which we can work right now is the good old block quote. Read more in #393 (comment).

@Reinmar Reinmar self-assigned this Feb 9, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Feb 19, 2017

I've been thinking how to implement this feature in the simplest possible way. The first issue was how to get the list of selected elements to wrap with a quote. I want to base that on the "block" type of elements (defined by the schema – read more here: https://github.com/ckeditor/ckeditor5-engine/issues/532#issuecomment-280916457). Only those blocks will be wrappable and the <messageQuote> element must be their immediate parent. This will simplify the implementation a lot.

@Reinmar
Copy link
Member Author

Reinmar commented Feb 19, 2017

Another assumption – in the first version subsequent quotes won't be merged when creating them or deleting content between two existing ones. In fact, perhaps this should be the target behaviour of the message quote feature.

@scofalik
Copy link
Contributor

I think this should be final behaviour. I can easily imagine situation when you want to quote multiple parts of message and respond to them all at once. You don't want them to be merged. The only situation when I'd consider merging quotes is when executing delete command. If caret was at the end/beginning of quote and user pressed delete/backspace key. Then we could merge.

@Reinmar Reinmar changed the title Implement the message quote feature Implement the block quote feature Mar 27, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Mar 27, 2017

Small change of plans – we realised that we are implementing the good old block quote feature now. Read more in #393 (comment).

I'll rename this package and all files accordingly.

@Reinmar
Copy link
Member Author

Reinmar commented Mar 27, 2017

Besides renaming, it seems that this is the only problem right now: https://github.com/ckeditor/ckeditor5-engine/issues/710

So, I'll create a PR in this repo very soon.

scofalik referenced this issue in ckeditor/ckeditor5-block-quote Mar 30, 2017
Feature: Introduced the block quote feature. Closes #1.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-block-quote Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:block-quote labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:block-quote type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants