[Chrome] Handle pasted whitespaces #25
Conversation
| @@ -17,4 +17,44 @@ describe( 'normalizeClipboardData', () => { | |||
| normalizeClipboardData( '<span class="Apple-converted-space"> </span>x<span class="Apple-converted-space">\u00a0</span>' ) | |||
| ).to.equal( ' x ' ); | |||
| } ); | |||
|
|
|||
| it( 'should strip all spans with no attributes', () => { | |||
There was a problem hiding this comment.
I was wondering whether this is cleanup should be really done.
On one hand the data is correct and, hypothetically, there could be a plugin that creates empty spans and want them retained when copied from editor to editor.
On the other hand, in 99.9% of cases empty span is just a garbage because spans are used mostly to hold formatting. Also a feature that creates just an empty span is probably a bad practice and something that may blow up :).
So I think this is fine.
There was a problem hiding this comment.
You're right. The entire #2 is about this. We may lose some data. But, at least for now, it's more important to keep the content clean from non-breaking spaces. Then, we can somehow support copy-pasting them within the editor (they'd need to be marked in a special way when stringified to HTML). And we'll never be able to handle copy-pasting them from outside of the editor because, by converting many normal spaces to non-breaking ones, Chrome loses that data.
There was a problem hiding this comment.
And as for features which want to produce empty spans with no classes/attributes (cause that's what cleaned here), they will simply be incorrect. Just like you mentioned – they'd be treated as a garbage.
Suggested merge commit message (convention)
Fix: Whitespaces around inline elements will not be lost upon pasting. Closes ckeditor/ckeditor5#2662.