This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Fix: The upcast code was assuming that the editor uses a HTMLDataProc… #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on ckeditor/ckeditor5-core#205, therefore the CI failure. |
|
R+ for most of the changes. But I'm unsure about the changes in ckeditor5-core. |
This dependency has been removed. All green now. |
Just to be clear, the previous commit made it not necessary to touch core anymore. |
fredck
force-pushed
the
t/ckeditor5/5977
branch
from
577d6f9
to
9aa82f4
Compare
|
Force-pushed a rebase over v17.0.0. |
fredck
force-pushed
the
t/ckeditor5/5977
branch
from
4d9a093
to
18e36db
Compare
|
Force-pushed a rebase over v18.0.0. |
…essor, which is not always true.
…ersions of the markdown plugin.
|
Force-pushed a rebase over v19.0.0. |
|
Moved to ckeditor/ckeditor5#7297. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…essor, which is not always true.
Suggested merge commit message (convention)
Fix: code blocks upcasting throws when using the markdown DP. Closes ckeditor/ckeditor5#5977.