-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to create a CKEditor 5 setup without forking ckeditor5 repo? #112
Comments
BTW. Integrating CKEditor 5 building process into your project's building process is now a bit inconvenient, because the only safe approach would be to run |
Are you essentially requiring app developers using CKE5 to be using git, github, and related build tools (grunt / gulp)? Does that become an "implicit dependency"? In my case, my web app (a large scale CMS hybrid) is for a non-profit and was developed over several years by a series of individual volunteer developers (now that one is me). Therefore, not any real attention to git repos or build scripts. I am now moving in that direction to support multiple future developers, but thank goodness for the CKE4 builder web interface. You obviously need to build/distribute in a way that makes sense to you, but keep in mind that not all app developers may be using the same development practices as you are. (for better or for worse) |
Right now there's only the gulp based builder (actually – there's no bundler yet), but that's a temporary state. We'll definitely be releasing some kind of builds (perhaps for each Implementation). Additionally, we may develop an online builder, although it may come later (because giving it a nice GUI is a lot of work). |
Two more thoughts:
BTW. A related ticket: #50. |
Wouldn't be enough to define dependencies in The more I'm thinking of it the more I would like to have builder/dev task in separate repo. Copyint and creating a temporary project for CI building looks like a hack. |
I described the CI strategy in #45 (comment) |
Cleaning up old discussions. See #186. |
Right now the building process requires you to clone ckeditor5, install dependencies (including CKE5 packages which you want to include) and then running the builder.
It sounds OK, but I am afraid that it may be a bit cumbersome when working on implementations (CKEditor 5 dependent projects). If you have your project's repo (let's say
my-awesome-website
), you want to be able to addckeditor5
and a couple ofckeditor5-*
packages to yourpackage.json
, run the builder and do something with the output. With such a setup you're able to quickly upgrade everything by runningnpm update
in your project and to install new dependencies by simply callingnpm install --save ckeditor5-*
.If we require forking ckeditor5 developers will need to do 3 additional things:
package.json
, not someckeditor5
fork's configuration).Therefore, I'm opting strongly for enabling the former solution. We just need to learn the current builder to read CKEditor 5 packages from the same level at which
ckeditor5
is. A similar feature is also required for CI, because when running tests for a specific repo (ckeditor5-* package) that package is the starting point fornpm install
. Perhaps we'll be able to unify this cases, so CI runner will create a simple temporary project includingckeditor5
and the package that needs to be tested.The text was updated successfully, but these errors were encountered: