Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise dependencies and devDependencies #74

Closed
Reinmar opened this issue Jan 29, 2016 · 3 comments
Closed

Reorganise dependencies and devDependencies #74

Reinmar opened this issue Jan 29, 2016 · 3 comments
Assignees
Labels
resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior).

Comments

@Reinmar
Copy link
Member

Reinmar commented Jan 29, 2016

Related to ckeditor/ckeditor5-design#112

It should be possible to use gulp build when the ckeditor5 package is installed as your project's dependency. This means that we need to move some dependencies from dev to normal ones.

@Reinmar
Copy link
Member Author

Reinmar commented Jan 29, 2016

At the same time ckeditor5-* (other than ckeditor5-core which is a hard dependency) dependencies which we have defined in the dependencies section should be moved to devDependencies, because we only want them installed while we're developing the thing. (But there are no other deps right now, so no changes are needed :D).

@Reinmar
Copy link
Member Author

Reinmar commented Jan 29, 2016

OK, I pushed branch t/74 but I cannot test that gulp build works, because existing tasks try to load non-existing modules. We would need to start including modules inside tasks, which isn't that bad idea taken that I've read that requiring so many modules hits the IO hard and slows down gulp tasks heavily.

@Reinmar Reinmar modified the milestone: 0.1.0 Mar 4, 2016
@Reinmar Reinmar removed this from the 0.1.0 milestone Apr 6, 2016
@Reinmar Reinmar added this to the 0.2.0 milestone Jun 22, 2016
@Reinmar Reinmar self-assigned this Jul 7, 2016
@Reinmar
Copy link
Member Author

Reinmar commented Jul 25, 2016

We focused now on making it possible to fork ckeditor5 or install ckeditor5-dev-* packages directly in your project. This means that it's not clear how dependencies in ckeditor5 must be split because it's only a dev environment for CKEditor 5, so it should always be used in a dev mode.

@Reinmar Reinmar closed this as completed Jul 25, 2016
@Reinmar Reinmar added resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). and removed status:confirmed labels Jul 25, 2016
@Reinmar Reinmar removed this from the iteration 2 milestone Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior).
Projects
None yet
Development

No branches or pull requests

1 participant