Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog boxes #179

Closed
kikkauz opened this issue Aug 8, 2017 · 3 comments
Closed

dialog boxes #179

kikkauz opened this issue Aug 8, 2017 · 3 comments

Comments

@kikkauz
Copy link

kikkauz commented Aug 8, 2017

Hello

Does ckeditor5 allow at this stage to develop plugins with dialog boxes? I tried to search in the code and the documentation but I cannot find anything about it. Is it something alreaduy existing but still to be documented? If so, could you please point me to which part of the code implements it?
If no, why is it not in the roadmap? :-)

Thanks!

Kikkauz

@Reinmar
Copy link
Member

Reinmar commented Aug 8, 2017

Hi @kikkauz!

No, we don't use dialog boxes (also called "modal boxes") in the existing UI and hence we also haven't implemented such a UI component.

I'm not sure whether we have a single place where the decision to stop using dialog boxes (used heavily and for pretty much everything in CKE4) was explained. Maybe @oleq remembers some tickets.

Anyway, dialog boxes are heavily intrusive UI components and are also hard to do right (focus management for instance). As long as we won't need them, we won't use them. Contextual panels like these work better (although, they turned to be tricky to implement and use too :D):

image

image

image

We can show them more frequently without disturbing the editing too much.

Therefore, there's no UI component for dialog box and we don't plan to create any. You could create one using the UI framework but if you can avoid that and just use contextual panels we think that it will be better.

@kikkauz
Copy link
Author

kikkauz commented Aug 8, 2017

Hello

thanks for the quick answer.
I'll have a look at that hoping it can cover the uses cases I'll have to face.

Kikkauz

@kikkauz kikkauz closed this as completed Aug 8, 2017
@oleq
Copy link
Member

oleq commented Aug 8, 2017

The issue was discussed in #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants