-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Quick content editing #97
Comments
There is also the current tendency to have small floating panels under links, like GDocs. They add very little Ui cluttering. Should we enlarge the samples with it? |
@fredck Those panels in GDocs show the url of the link and "Change" button. When clicked "Change", they convert into "Inline (balloon–like) editing". So I think we already consider this option and there's no such need. |
I really like ideas of balloons. I think they do not break user experience as much as dialogs. To answer your questions:
|
Balloons are nice, but may not work depending on the content since they require both the affected content and the balloon to be shown (more screen space needed). Personally, I like the ckeditor dialogs. Very flexible and w/ tabs can contain a lot of good stuff. |
+1 for considering alternatives to dialogs. Dialogs don't work on smartphones. (Or at least I haven't seen them work yet.) +1 for balloons. But they e.g. don't work for images I think. What about a CKEditor Widget-like approach combined with the "Show Blocks" button's ability to show the structure, but then enhanced? I can imagine keeping everything super simple, but upon adding new non-simple-text content, this newly added content is displayed in "structure mode", which causes a "Widget-slash-Show-Blocks-like" view, which therefore shows the image's Benefits:
|
Sounds like a fun. But what to to when a number of "inline inputs" is needed (like alt, width, height, url, upload button, etc.)? It would end up with an "inline monster". |
In my opinion dialogs just do the work. Tabs could also be a good solution but.. (reason below) Baloons looks very nice, but I have doubts about them:
|
What I see is that maybe a progressive enhancement type of strategy is called for. I can see where dialogs would not work on smartphones, but I think they do work fine on the desktop. It is clear that a UI strategy that fully embraces mobile is needed. However, please don't forget about desktops in the process and what the ckeditor UI already does well on the desktop. After all, I take issue with any one that believes they can do much more than basic editing with basic formatting on a smartphone. IMHO, things like embedding an iframe... things that dialogs are actually helpful for, are still best done on a larger screen. So maybe a different approach is called for on smaller screens. However, can you do the progressive enhancement approach (or similar) to enable what works better on a larger screen to be used? Also, keep in mind that a lot of extra stylistic "bling" may make ckeditor more difficult to integrate stylistically into a finished, polished web application. I treat ckeditor as functionality that acts a lot like a full application, but really isn't. Please do not forget that in most cases, ckeditor and its UI need to be able to be integrated into someone's web application. Thus, I tend towards the "keep it simple" thinking but hope you will implement provisions to allow for "bling" to be added as needed. |
I couldn't agree more that dialogs are a better deal. At the same time, I don't understand why you guys keep pointing that dialogs are not good for smartphones and why a ballon would make it work there. Actually, I feel that's quite the opposite. It would be simpler to find a way to show a dialog full screen in a smartphone than having the user to control scrolling to see the ballon contents. Other than that, I think that a "quick editing" solution like the one presented in GDocs for links is definitely welcome but I seet this is a different feature for a separate discussion. |
Good point! |
Please, don't confuse desktop UX with mobile at the moment. CKEditor 5 may end up with completely different solutions for these environments i.e. balloons and dialogs, as seen on the desktop, may become one and the same "fullscreen dialog" on mobile. So let's focus on desktop UI first because mobile is a separate topic, to be discussed later. |
So what you're saying is "let's take a desktop-first approach."? :) |
Yes. That's the common expectation set by Google etc.
Not if the field label is sufficient as it is here.
Yes, it should have the "x". And cancel is not absolutely necessary. AFAIU for A11y "cancel" can be the Aria name of the "x" button that is read out. Also clicking "away" from the bubble should close it. This is becoming expected behavior.
Dialogs are old school. Users are comfortable with the bubble pattern. It appears all over the web. |
I've not once seen a dialog in a browser working well on a smartphone. Especially when the keyboard is also visible. Can you post screenshots of example dialogs in web browsers on smartphones that work well? |
Not precisely. I'm not sure whether there's an issue for that already, but we've been discussing that desktop and bigger touch devices are one case and small touch devices are a second case. So what @oleq meant was that for now we'll focus on the UI for bigger screen resolutions. The small screens like iPhone introduce such limitation (there's so little space when the on-screen keyboard is visible, that you can barely display anything) that they have to be solved separately, because no normal solutions will work there. Please note also that we're not talking here about designing a webpage where you have the full area of the iPhone's screen and you can simply make your webpage responsive and be happy. Editor needs the keyboard (on which we don't have any control), selection (which sets some design requirements as well), ability to open dropdowns and other panels without ultimately breaking the selection, etc. Hence, in our opinion we won't be able to design a single solution that will work for all types of devices without making the UX on some of them worse than it could be. So no – no "desktop-first approach" ;). |
tl;dr for @Reinmar's response is: "There will probably be a totally separate UI for small mobile devices because WYSIWYG on mobile is extremely hard to implement.". |
That wasn't a lossless compression :P. |
Sure, but if there are to be two approaches always better to tackle the harder one first. Especially if the process leads to discovery of a solution that does indeed work for both, something which is impossible to rule out. |
Cleaning up outdated discussions. See #186 |
Are dialogs still the right way of editing content?
Inline (balloon–like) editing
Dialog editing
In–toolbar editing (super–contextual toolbar)
The text was updated successfully, but these errors were encountered: